implode() problem PHP7.4

almostcompletely

I get this message on my site when I first open it fresh each day. It happens both on the front end or the Fuel dashboard and only occurs on the first page load. It disappears for the rest of the day after that.

A PHP Error was encountered
Severity: 8192
Message: implode(): Passing glue string after array is deprecated. Swap the parameters
Filename: Unknown
Line Number: 0
Backtrace:

You'd think it would be just an easy task of searching for "implode" in the code and fixing it? It seems not. I've searched using text search tools from the root of the project directory and can find no offending code.

It's obviously related to sessions or cookies due to it only happening on a fresh load. It's also somewhere in the core code since there's no filename or line number reported.

It's also obviously a Fuel/CI thing since it presents in the usual CI format.

This does not happen on older versions of PHP - my publicly hosted version of the same site is on PHP7.2 with no problems.

Any ideas anyone?

admin

No line numbers huh? Have you tried it with the latest develop branch by chance?

almostcompletely

Turned out this is caused by the Search module.

Line 59: https://github.com/daylightstudio/FUEL-CMS-Search/blob/master/models/Search_model.php

$full_text_indexed = implode($full_text_fields, ', ');

Should be:

$full_text_indexed = implode(', ', $full_text_fields);

admin

Thanks for the report. I've pushed an update for that.

katesmith1304

Old PHP code.

The language has really come a long way recently but there is still a lot of old school out there...

The worst parts of PHP are in the past.

katesmith1304

Old PHP code.

The language has really come a long way recently but there is still a lot of old school out there....

The worst parts of PHP are in the past.

nop reply?