simple module feature/1.4_dev

hemingweb

I've created the simplest of modules:

Database table of manufacturers

MY_fuel_modules.php:

$config['modules']['make'] = array();

model (make_model.php):

<?php if (!defined('BASEPATH')) exit('No direct script access allowed');

require_once(FUEL_PATH.'models/base_module_model.php');
require_once(MODULES_PATH.'/blog/config/blog_constants.php');

class Make_model extends Base_module_model {

public function __construct() {
parent::__construct('Make');
}

function list_items($limit = NULL, $offset = NULL, $col = 'make_name', $order = 'asc', $just_count = FALSE) {
$this->db->select('id, make_name, make_title');
$data = parent::list_items($limit, $offset, $col, $order);
return $data;
}
}

I'm logged in as admin (super user)

In the form_fields view I get the following error:

A PHP Error was encountered
Severity: Runtime Notice
Message: Only variables should be assigned by reference
Filename: models/base_module_model.php
Line Number: 1487

Any idea as to where I've gone wrong?

hemingweb

I'm developing with php5.5.29 and deploying to php 5.4

Sent a pull request.

admin

I'm not seeing the pull request. Was it just removing the & ?

hemingweb

Hi Dave,

sorry about that, still finding my way around github.

Yep, it was just the '&'

Cheers

David