PHP 5.5 and preg_replace function depracation

Comments

• admin

  November 2013 edited 5:02PM

  Not yet. The e modifier is used in a few spots and those areas need to be updated to use the callback instead. We will have this before the 1.0 release but until then you'll have to either use 5.4 or implement the fix. If you do the latter, let us know or better yet, put it in a pull request.
  https://github.com/daylightstudio/FUEL-CMS/tree/1.0
• admin

  November 2013 edited November 2013

  What if you try replacing that line with something like the following:
  //e modifier is deprecated if (version_compare(PHP_VERSION, '5.5', '>=')) { $url = preg_replace_callback('#^(.*)\{(.+)\}(.*)$#', function($match) use ($fields) { if (!empty($match[2])) { return $match[1].$fields[$match[2]].$match[3]; } return ''; }, $val['url']); } else { $url = preg_replace('#^(.*)\{(.+)\}(.*)$#e', "'\\1'.((!empty(\$fields['\\2'])) ? \$fields['\\2'] : '').'\\3'", $val['url']); }
• ChrisHPZ

  November 2013 edited 5:02PM

  That would have taken me a month to write, but I will try that and report back. Thanks brother :-)
• ChrisHPZ

  November 2013 edited 5:02PM

  Wow, that worked:-) Thanks again admin. I've pasted the code for this particular function below in its entirety.
  
  protected function _render_actions($actions, $fields)
  {
  $str = '';
  $actions = array();
  foreach($this->_actions as $key => $val)
  {
  // normalize the data
  if (!is_array($val))
  {
  $val = array('url' => $val);
  }
  if (!empty($val['func']))
  {
  $action = call_user_func($val['func'], $fields);
  if (!empty($action)) $actions[] = $action;
  }
  else
  {
  // i love regexp... key is the e modifier that evaluates the code
  //e modifier is deprecated
  if (version_compare(PHP_VERSION, '5.5', '>='))
  {
  $url = preg_replace_callback('#^(.*)\{(.+)\}(.*)$#',
  function($match) use ($fields) {
  if (!empty($match[2]))
  {
  return $match[1].$fields[$match[2]].$match[3];
  }
  return '';
  }, $val['url']);
  }
  else
  {
  $url = preg_replace('#^(.*)\{(.+)\}(.*)$#e', "'\\1'.((!empty(\$fields['\\2'])) ? \$fields['\\2'] : '').'\\3'", $val['url']);
  }
  $attrs = (!empty($val['attrs'])) ? ' '.$this->_render_attrs($val['attrs']) : '';
  $actions[] =''.$key.'';
  }
  
  }
  if (!empty($actions)) $str = implode('  '.$this->action_delimiter.'  ', $actions);
  return $str;
  }
  
  }
• admin

  November 2013 edited 5:02PM

  Also, this change has been pushed into the 1.0 branch.
• alleyhector

  July 2015 edited 5:02PM

  So what would be this same fix for
  
  Filename: libraries/fuel_page.php
  Line Number: 646
  
  The code is:
  
  $output = preg_replace('/(<body[^>]*>)/e', '"\\1\n".\$head_markers', $output);
• admin

  August 2015 edited 5:02PM

  In the newest version of FUEL, look at the Fuel_pages::render_all_markers() method.